Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable stacktrace related test for sanitized UT #4463

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

Signed-off-by: SchrodingerZhu [email protected]

What problem does this PR solve?

Issue Number: close #4462

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@SchrodingerZhu SchrodingerZhu self-assigned this Mar 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
@SchrodingerZhu
Copy link
Contributor Author

/run-sanitizer-test asan tsan

@SchrodingerZhu SchrodingerZhu changed the title disable sanitizing for stacktrace related UT disable stacktrace related test for sanitizedUT Mar 28, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
@SchrodingerZhu SchrodingerZhu force-pushed the schrodingerzhu/skip-sanitizer-for-stacktrace branch from b2cc6b5 to 162e9f2 Compare March 28, 2022 07:50
@SchrodingerZhu SchrodingerZhu changed the title disable stacktrace related test for sanitizedUT disable stacktrace related test for sanitized UT Mar 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 162e9f2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

Filename                                                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/tests/gtest_stacktrace.cpp          68                 3    95.59%           6                 0   100.00%          54                 0   100.00%          28                 9    67.86%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                          68                 3    95.59%           6                 0   100.00%          54                 0   100.00%          28                 9    67.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17049      9576             43.83%    191778  97001        49.42%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 6cfbd20 into master Mar 28, 2022
@SchrodingerZhu SchrodingerZhu deleted the schrodingerzhu/skip-sanitizer-for-stacktrace branch April 1, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip stacktrace UT when sanitizer enabled
5 participants