Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATED] Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) #4211

Closed
wants to merge 7 commits into from
Closed

[DEPRECATED] Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) #4211

wants to merge 7 commits into from

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Mar 9, 2022 •
edited
Loading

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

Reference: grpc/grpc#23144

Change to use boringssl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the potential crash issue that occurs when TLS is enabled

@solotzg solotzg added the type/enhancement The issue or PR belongs to an enhancement. label Mar 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 9, 2022

/run-all-tests

1 similar comment
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/run-all-tests

@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/run-unit-test

@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1780/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49808 out of 114023)
branches: 6.5% (81427 out of 1262352)

@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1786/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49808 out of 114023)
branches: 6.5% (81427 out of 1262352)

@solotzg
update ci/cd process
43387df 
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1788/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49811 out of 114023)
branches: 6.4% (81421 out of 1262352)

@zanmato1984
Copy link
Contributor

Just to confirm: bundling proxy is a non-goal, right?

zanmato1984
zanmato1984 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

Just to confirm: bundling proxy is a non-goal, right?

Yes.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 23e28d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Mar 10, 2022

After manual tests, build process under arm64 works fine.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1810/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49808 out of 114023)
branches: 6.4% (81418 out of 1262352)

@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/rebuild

@solotzg
Copy link
Contributor Author

solotzg commented Mar 15, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

lines: 43.3% (49807 out of 115122)
branches: 6.4% (81411 out of 1263882)

@solotzg solotzg self-assigned this Mar 21, 2022
@LittleFall LittleFall mentioned this pull request Mar 21, 2022
Merged
12 tasks
@solotzg solotzg reopened this Mar 27, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Apr 1, 2022

/rebuild

@LittleFall LittleFall mentioned this pull request Apr 6, 2022
Merged
12 tasks
@solotzg solotzg added the type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. label Apr 6, 2022
This was referenced Apr 6, 2022
Merged
Merged
@solotzg solotzg added this to the v5.4.1 milestone Apr 12, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2022

Close because of illegal base branch. Reopen in #4689.

@solotzg solotzg closed this Apr 18, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 18, 2022

lines: 43.3% (49813 out of 115122)
branches: 6.4% (81423 out of 1263882)

@solotzg solotzg removed type/enhancement The issue or PR belongs to an enhancement. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Apr 18, 2022
@solotzg solotzg removed this from the v5.4.1 milestone Apr 18, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 21, 2022
@solotzg solotzg changed the title Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) [DEPRECATED] Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974) (#3987) Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees

@solotzg solotzg

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@solotzg @ti-chi-bot @sre-bot @zanmato1984 @SchrodingerZhu @VelocityLight