Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully rename project to tiflash #3901

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Fully rename project to tiflash #3901

merged 3 commits into from
Jan 21, 2022

Conversation

zanmato1984
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2022
@zanmato1984
Copy link
Contributor Author

/run-all-tests

@zanmato1984 zanmato1984 changed the title Fully rename project to tiflash WIP: Fully rename project to tiflash Jan 19, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 19, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1072/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51496 out of 115167)
branches: 7.0% (89802 out of 1275204)

fuzhe1989
fuzhe1989 reviewed Jan 20, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2022
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 21, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1111/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51535 out of 115235)
branches: 7.0% (89847 out of 1274914)

@zanmato1984 zanmato1984 changed the title WIP: Fully rename project to tiflash Fully rename project to tiflash Jan 21, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2022
JaySon-Huang
JaySon-Huang approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 21, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b6583a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 21, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1112/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51535 out of 115235)
branches: 7.0% (89851 out of 1274914)

@ti-chi-bot ti-chi-bot merged commit fbccbfd into pingcap:master Jan 21, 2022
@JaySon-Huang JaySon-Huang deleted the full-rename-project branch January 21, 2022 13:13
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 22, 2022
Merged
12 tasks
@solotzg solotzg mentioned this pull request Mar 10, 2022
Closed
12 tasks
LittleFall referenced this pull request in LittleFall/tics Mar 21, 2022
@zanmato1984 @LittleFall
Bundle grpc/protobuf in tiflash (#3896)
748d5ab 
Fully rename project to tiflash (#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (#3974)

Bundle all dependencies: zlib, openssl and curl (#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <[email protected]>

fix zlib-ng

Signed-off-by: Zhigao Tong <[email protected]>
LittleFall referenced this pull request in LittleFall/tics Mar 21, 2022
@zanmato1984 @LittleFall
Bundle grpc/protobuf in tiflash (#3896)
a7a06a1 
Fully rename project to tiflash (#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (#3974)

Bundle all dependencies: zlib, openssl and curl (#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <[email protected]>

fix zlib-ng

Signed-off-by: Zhigao Tong <[email protected]>
@LittleFall LittleFall mentioned this pull request Mar 21, 2022
Merged
12 tasks
LittleFall pushed a commit to LittleFall/tiflash that referenced this pull request Apr 6, 2022
@zanmato1984
Bundle grpc/protobuf in tiflash (pingcap#3896)
c31bb0f 
Fully rename project to tiflash (pingcap#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (pingcap#3974)

Bundle all dependencies: zlib, openssl and curl (pingcap#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <[email protected]>

fix zlib-ng

Signed-off-by: Zhigao Tong <[email protected]>

extra fix

formatted
@LittleFall LittleFall mentioned this pull request Apr 6, 2022
Merged
12 tasks
LittleFall pushed a commit to LittleFall/tiflash that referenced this pull request Apr 6, 2022
@zanmato1984 @LittleFall
Bundle grpc/protobuf in tiflash (pingcap#3896)
405580b 
Fully rename project to tiflash (pingcap#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (pingcap#3974)

Bundle all dependencies: zlib, openssl and curl (pingcap#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <[email protected]>

fix zlib-ng

Signed-off-by: Zhigao Tong <[email protected]>

extra fix

formatted

fix: remove dttool, unify definition

fix: add functions

fix: replace ClickHouse to TiFlash
@LittleFall LittleFall mentioned this pull request Apr 6, 2022
Merged
12 tasks
LittleFall pushed a commit to LittleFall/tiflash that referenced this pull request Apr 6, 2022
@zanmato1984 @LittleFall
Bundle grpc/protobuf in tiflash (pingcap#3896)
160ceac 
Fully rename project to tiflash (pingcap#3901)

Conflicts:
	libs/libdaemon/cmake/find_unwind.cmake

Remove useless curl dependency (pingcap#3974)

Bundle all dependencies: zlib, openssl and curl (pingcap#3987)

Conflicts:
	contrib/poco

update contrib/poco

update ci/cd process

Signed-off-by: Zhigao Tong <[email protected]>

fix zlib-ng

Signed-off-by: Zhigao Tong <[email protected]>

extra fix

formatted

fix: remove dttool, unify definition

fix: add functions

fix: replace ClickHouse to TiFlash

fix: update dtpb cmake

fix: compile issue

fmt

fix: gtests

fix: gtests scripts
@LittleFall LittleFall mentioned this pull request Apr 6, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 11, 2022
@LittleFall
Bundle grpc/protobuf curl zlib ssl in release-5.2 (#3896) (#3901) (#3974
15b2664 
) (#3987) (#4591)

close #4196
@solotzg solotzg mentioned this pull request Apr 18, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2022
@LittleFall
Bundle grpc/protobuf curl zlib ssl in release-5.1 (#3896) (#3901) (#3974
d655595 
) (#3987) (#4599)

close #4196
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2022
@solotzg
Bundle grpc/protobuf curl zlib ssl in release-5.4 (#3896) (#3901) (#3974
5d8e89f 
)  (#3987) (#4689)

close #4196
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2022
@LittleFall
Bundle grpc/protobuf curl zlib ssl in release-5.3 (#3896) (#3901) (#3974
ba1f109 
) (#3987) (#4369)

close #4196
ti-chi-bot pushed a commit that referenced this pull request May 11, 2022
@LittleFall
Bundle grpc/protobuf curl zlib ssl in release-5.0 (#3896) (#3901) (#3974
94609a6 
) (#3987) (#4600)

close #4196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zanmato1984 @ti-chi-bot @sre-bot @JaySon-Huang @fuzhe1989