Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug from pull request 4042 #4190

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix bug from pull request 4042 #4190

merged 1 commit into from
Mar 7, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

fix bug from #4042

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/run-all-tests

@SeaRise SeaRise requested a review from fuzhe1989 March 7, 2022 09:17
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp         327               327     0.00%          39                39     0.00%         742               742     0.00%         254               254     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                    327               327     0.00%          39                39     0.00%         742               742     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9458             43.40%    187257  95518        48.99%

full coverage report (for internal network access only)

@SeaRise SeaRise requested review from LittleFall and windtalker March 7, 2022 09:30
windtalker
windtalker approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe472b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp         327               327     0.00%          39                39     0.00%         742               742     0.00%         254               254     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                    327               327     0.00%          39                39     0.00%         742               742     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9458             43.40%    187257  95543        48.98%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit acae5c1 into pingcap:master Mar 7, 2022
@SeaRise SeaRise deleted the fix_err_from_4042 branch March 7, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@windtalker windtalker windtalker approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @fuzhe1989