Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine appendAggregation in analyzer #4042

Merged
merged 30 commits into from
Mar 7, 2022
Merged

refine appendAggregation in analyzer #4042

merged 30 commits into from
Mar 7, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Feb 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

1、refactor and move count_second_stage, getAggFuncName, isUInt8Type and constructTZExpr to namespace {}
2、replace arg ExpressionActionsChain::Step & step of buildGroupConcat/buildCommonAggFunc/appendCastAfterAgg by ExpressionActionsPtr & actions and move set required_output to appendAggregation
3、add function buildAggGroupBy， buildAggFuncs, fillAggArgumentDetail, findDuplicateAggFunc and appendAggDescription to refine the code of appendAggregation
4、add getLastStepOfChain to replace chain.steps.back()

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 16, 2022

/run-integration-test

@SeaRise SeaRise changed the title refine analyzer for planner [WIP] refine analyzer for planner Feb 16, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 16, 2022

/run-integration-test

@SeaRise SeaRise changed the title [WIP] refine analyzer for planner refine analyzer for planner Feb 16, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022
@SeaRise SeaRise requested a review from windtalker February 16, 2022 06:53
@SeaRise SeaRise changed the title refine analyzer for planner refine appendAggregation in analyzer for planner Feb 16, 2022
@SeaRise SeaRise changed the title refine appendAggregation in analyzer for planner refine appendAggregation in analyzer Feb 16, 2022
@SeaRise SeaRise requested a review from LittleFall February 16, 2022 07:43
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 18, 2022

/run-integration-test

@SeaRise SeaRise requested a review from fuzhe1989 March 3, 2022 10:20
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2022

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2022

/run-integration-test

@SeaRise SeaRise requested a review from fuzhe1989 March 4, 2022 03:00
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 4, 2022

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp               327               327     0.00%          39                39     0.00%         743               743     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h                   2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
DAGExpressionAnalyzerHelper.cpp          86                86     0.00%          12                12     0.00%         223               223     0.00%          64                64     0.00%
DAGQueryBlockInterpreter.cpp            376               376     0.00%          44                44     0.00%         850               850     0.00%         304               304     0.00%
DAGUtils.cpp                            290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
DAGUtils.h                                3                 0   100.00%           1                 0   100.00%          12                 0   100.00%           2                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1084              1024     5.54%         134               121     9.70%        2335              2222     4.84%         948               852    10.13%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16709      9463             43.37%    187170  95569        48.94%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7bd8152

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp               327               327     0.00%          39                39     0.00%         743               743     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h                   2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
DAGExpressionAnalyzerHelper.cpp          86                86     0.00%          12                12     0.00%         223               223     0.00%          64                64     0.00%
DAGQueryBlockInterpreter.cpp            376               376     0.00%          44                44     0.00%         850               850     0.00%         304               304     0.00%
DAGUtils.cpp                            290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
DAGUtils.h                                3                 0   100.00%           1                 0   100.00%          12                 0   100.00%           2                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1084              1024     5.54%         134               121     9.70%        2335              2222     4.84%         948               852    10.13%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16711      9458             43.40%    187258  95538        48.98%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 7a9be88 into pingcap:master Mar 7, 2022
@SeaRise SeaRise mentioned this pull request Mar 7, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@windtalker windtalker windtalker approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @fuzhe1989 @XuHuaiyu