Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3480

Merged
merged 5 commits into from
Jun 17, 2022
Merged

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3480

merged 5 commits into from
Jun 17, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3463

What problem does this PR solve?

Issue Number: close #3447

Problem Summary:

The result of where <string> is wrong because it will be converted to int type.

What is changed and how it works?

Proposal: xxx

What's Changed: convert it to double type to keep compatible with tidb/tikv.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test

Side effects

Release note 

Fix the bug that results of `where <string>` is wrong because it will be converted to int type.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2021
Merged
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Nov 18, 2021
@JaySon-Huang JaySon-Huang added this to the v5.3.1 milestone Dec 9, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.3.1, v5.3.2 May 11, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2022
@LittleFall LittleFall requested a review from windtalker June 17, 2022 10:03
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2022
@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a537937

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall
Copy link
Contributor

Static Analysis failed, i will disable it temply

@LittleFall
Copy link
Contributor

/rebuild

@LittleFall
Copy link
Contributor

/run-integration-test

@LittleFall LittleFall mentioned this pull request Jun 17, 2022
Merged
12 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 17, 2022

lines: 36.0% (43096 out of 119618)
branches: 5.4% (66195 out of 1223135)

@ti-chi-bot ti-chi-bot merged commit 3b3e86c into pingcap:release-5.3 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@LittleFall LittleFall

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3
Projects
None yet
Milestone
v5.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @LittleFall @sre-bot @gengliqi @JaySon-Huang @VelocityLight