Fix the bug that results of `where <string>` is wrong because it will be converted to int type. #3463

LittleFall · 2021-11-17T06:59:59Z

What problem does this PR solve?

Issue Number: close #3447

Problem Summary:

The result of where <string> is wrong because it will be converted to int type.

What is changed and how it works?

Proposal: xxx

What's Changed: convert it to double type to keep compatible with tidb/tikv.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch:

Check List

Tests

Unit test

Side effects

Release note

Fix the bug that results of `where <string>` is wrong because it will be converted to int type.

ti-chi-bot · 2021-11-17T07:00:00Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

LittleFall · 2021-11-17T07:42:26Z

/run-all-tests

sre-bot · 2021-11-17T07:57:02Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/88/cobertura/

fuzhe1989 · 2021-11-17T13:17:41Z

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp

@@ -877,7 +877,7 @@ String DAGExpressionAnalyzer::convertToUInt8(ExpressionActionsPtr & actions, con
    // the basic rule is:
    // 1. if the column is only null, just return it
    // 2. if the column is numeric, compare it with 0
-    // 3. if the column is string, convert it to numeric column, and compare with 0
+    // 3. if the column is string, convert it to float-point column, and compare with 0


how does tidb/mysql solve this problem?

TiDB convert the string to float

windtalker

LGTM

windtalker · 2021-11-18T01:40:39Z

Note this pr can not simply be cherry-picked to other branch, since not all the version support cast_string_as_real.

LittleFall · 2021-11-18T07:03:13Z

there is a compatible issue in cast string as real. #3475

LittleFall · 2021-11-18T07:38:48Z

Note this pr can not simply be cherry-picked to other branch, since not all the version support cast_string_as_real.

you'are right, so because the severity of the bug is a bit low and 4.0 does not support cast string as real push down, we will not cherry-pick it to 4.0. cc @windtalker @fuzhe1989

LittleFall · 2021-11-18T07:39:42Z

/merge

ti-chi-bot · 2021-11-18T07:39:42Z

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-11-18T07:39:49Z

This pull request has been accepted and is ready to merge.

Commit hash: 641698e

sre-bot · 2021-11-18T07:53:13Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/108/cobertura/

ti-chi-bot · 2021-11-18T08:08:26Z

In response to a cherrypick label: new pull request created: #3476.

ti-chi-bot · 2021-11-18T08:09:05Z

In response to a cherrypick label: new pull request created: #3477.

ti-chi-bot · 2021-11-18T08:09:42Z

In response to a cherrypick label: new pull request created: #3478.

ti-chi-bot · 2021-11-18T08:10:19Z

In response to a cherrypick label: new pull request created: #3479.

ti-chi-bot · 2021-11-18T08:10:56Z

In response to a cherrypick label: new pull request created: #3480.

… be converted to int type. (#3463) (#3477)

… be converted to int type. (#3463) (#3478)

… be converted to int type. (#3463) (#3479) close #3447

… be converted to int type. (#3463) (#3480) close #3447

fix

202990b

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021

LittleFall and others added 2 commits November 17, 2021 15:00

Merge branch 'master' into bugfix/3447

ecbd30a

add test

4fa9f89

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021

LittleFall requested a review from windtalker November 17, 2021 07:22

add

0ee0960

LittleFall force-pushed the bugfix/3447 branch from 0fbfbdb to 0ee0960 Compare November 17, 2021 07:42

fuzhe1989 reviewed Nov 17, 2021

View reviewed changes

windtalker approved these changes Nov 18, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021

Merge branch 'master' into bugfix/3447

641698e

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021

ti-chi-bot merged commit 64e80c9 into pingcap:master Nov 18, 2021

ti-chi-bot mentioned this pull request Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3476

Closed

ti-chi-bot mentioned this pull request Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3477

Merged

ti-chi-bot mentioned this pull request Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3478

Merged

ti-chi-bot mentioned this pull request Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3479

Merged

ti-chi-bot mentioned this pull request Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. (#3463) #3480

Merged

LittleFall removed the needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 label Nov 18, 2021

LittleFall deleted the bugfix/3447 branch November 18, 2021 09:51

ti-chi-bot added a commit that referenced this pull request Dec 20, 2021

Fix the bug that results of where <string> is wrong because it will…

f178659

… be converted to int type. (#3463) (#3477)

ti-chi-bot added a commit that referenced this pull request Jan 26, 2022

Fix the bug that results of where <string> is wrong because it will…

485fe78

… be converted to int type. (#3463) (#3478)

ti-chi-bot added a commit that referenced this pull request Apr 14, 2022

Fix the bug that results of where <string> is wrong because it will…

31f7c7e

… be converted to int type. (#3463) (#3479) close #3447

ti-chi-bot added a commit that referenced this pull request Jun 17, 2022

Fix the bug that results of where <string> is wrong because it will…

3b3e86c

… be converted to int type. (#3463) (#3480) close #3447

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the bug that results of `where <string>` is wrong because it will be converted to int type. #3463

Fix the bug that results of `where <string>` is wrong because it will be converted to int type. #3463

LittleFall commented Nov 17, 2021 •

edited

Loading

ti-chi-bot commented Nov 17, 2021 •

edited

Loading

LittleFall commented Nov 17, 2021

sre-bot commented Nov 17, 2021

fuzhe1989 Nov 17, 2021

windtalker Nov 18, 2021

windtalker left a comment

windtalker commented Nov 18, 2021

LittleFall commented Nov 18, 2021 •

edited

Loading

LittleFall commented Nov 18, 2021

LittleFall commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

sre-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

Fix the bug that results of where <string> is wrong because it will be converted to int type. #3463

Fix the bug that results of where <string> is wrong because it will be converted to int type. #3463

Conversation

LittleFall commented Nov 17, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

ti-chi-bot commented Nov 17, 2021 • edited Loading

LittleFall commented Nov 17, 2021

sre-bot commented Nov 17, 2021

fuzhe1989 Nov 17, 2021

Choose a reason for hiding this comment

windtalker Nov 18, 2021

Choose a reason for hiding this comment

windtalker left a comment

Choose a reason for hiding this comment

windtalker commented Nov 18, 2021

LittleFall commented Nov 18, 2021 • edited Loading

LittleFall commented Nov 18, 2021

LittleFall commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

sre-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

ti-chi-bot commented Nov 18, 2021

Fix the bug that results of `where <string>` is wrong because it will be converted to int type. #3463

Fix the bug that results of `where <string>` is wrong because it will be converted to int type. #3463

LittleFall commented Nov 17, 2021 •

edited

Loading

ti-chi-bot commented Nov 17, 2021 •

edited

Loading

LittleFall commented Nov 18, 2021 •

edited

Loading