Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try copy libnsl.so to INSTALL_DIR (#3203) #3206

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3203

What problem does this PR solve?

Issue Number: close #2752

Problem Summary:

What is changed and how it works?

What's Changed:

  • try copy libnsl.so to ${INSTALL_DIR}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

Fix the issue that TiFlash fails to start up under platform without library `nsl`

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 labels Oct 14, 2021
@JaySon-Huang JaySon-Huang added this to the v5.1.3 milestone Oct 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2021
@solotzg solotzg modified the milestones: v5.1.3, v5.1.4 Dec 23, 2021
@solotzg
Copy link
Contributor

solotzg commented Jan 19, 2022

/rebuild

1 similar comment
@solotzg
Copy link
Contributor

solotzg commented Jan 19, 2022

/rebuild

@solotzg
Copy link
Contributor

solotzg commented Jan 19, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 62712b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@ti-chi-bot ti-chi-bot merged commit 75b7b60 into pingcap:release-5.1 Jan 24, 2022
@solotzg solotzg deleted the cherry-pick-3203-to-release-5.1 branch January 24, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants