Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try copy libnsl.so to INSTALL_DIR #3203

Merged
merged 5 commits into from
Oct 14, 2021
Merged

try copy libnsl.so to INSTALL_DIR #3203

merged 5 commits into from
Oct 14, 2021

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Oct 13, 2021

What problem does this PR solve?

Issue Number: close #2752

Problem Summary:

What is changed and how it works?

What's Changed:

  • try copy libnsl.so to ${INSTALL_DIR}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

Fix the issue that TiFlash fails to start up under platform without library `nsl`

@solotzg solotzg added the type/bugfix This PR fixes a bug. label Oct 13, 2021
@solotzg solotzg requested a review from birdstorm October 13, 2021 13:43
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • birdstorm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2021
@solotzg
Copy link
Contributor Author

solotzg commented Oct 13, 2021

/run-all-tests

@solotzg solotzg added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 labels Oct 13, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2021
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2021
@solotzg
Copy link
Contributor Author

solotzg commented Oct 14, 2021

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb83554

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2021
@ti-chi-bot ti-chi-bot merged commit 6575a03 into pingcap:master Oct 14, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3205.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3206.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3207.

@solotzg solotzg deleted the copy-libnsl branch October 14, 2021 01:48
@solotzg solotzg added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 and removed needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 labels Oct 14, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3209.

@solotzg solotzg added the needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 label Oct 14, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tics#release-4.0 from head ti-chi-bot:cherry-pick-3203-to-release-4.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-3203-to-release-4.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include libnsl in arm build
3 participants