-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storage configuration compatibility. #3019
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should totally remove bg_task_io_rate_limit
from our docs (for the master and 5.2).
Since it is only an experimental config in v5.0/v5.1 and we don't support it anymore since v5.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2f8938a
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #3049. |
What problem does this PR solve?
Issue Number: close #2781, close #1760
Problem Summary:
What is changed and how it works?
What's Changed:
storage.bg_task_io_rate_limit
.format_version
andlazily_init_store
fromTiFlashStorageConfig::parse
toTiFlashStorageConfig::parseMisc
, and callparseMisc
when configuration has[storage]
section.TiFlashStorageConfig::parse
toTiFlashStorageConfig::parseStoragePath
and callparseStoragePath
when configuration has[storage.main]
section instead of has[storage]
section.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note