Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast time as int #1760

Merged
merged 9 commits into from
Apr 15, 2021
Merged

Fix cast time as int #1760

merged 9 commits into from
Apr 15, 2021

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Apr 12, 2021

Signed-off-by: Yu Lei [email protected]

What problem does this PR solve?

Issue Number: close #1759

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Release note

  • Fix problem that TiFlash coprocessor's cast time as int function may produce incorrect result.

leiysky added 2 commits April 13, 2021 00:30
Signed-off-by: Yu Lei <[email protected]>
Signed-off-by: Yu Lei <[email protected]>
@leiysky leiysky added the type/bugfix This PR fixes a bug. label Apr 12, 2021
@leiysky leiysky requested a review from windtalker April 12, 2021 16:42
@leiysky
Copy link
Contributor Author

leiysky commented Apr 12, 2021

/run-all-tests

Signed-off-by: Yu Lei <[email protected]>
@leiysky
Copy link
Contributor Author

leiysky commented Apr 12, 2021

/run-all-tests

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Apr 13, 2021

/run-all-tests

@leiysky leiysky added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 labels Apr 13, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Apr 13, 2021

/rebuild

@leiysky
Copy link
Contributor Author

leiysky commented Apr 13, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Apr 13, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 1754

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 14, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 14, 2021

/build

@leiysky
Copy link
Contributor Author

leiysky commented Apr 14, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/build

@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

Signed-off-by: Yu Lei <[email protected]>
@leiysky
Copy link
Contributor Author

leiysky commented Apr 15, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 7572e20 into pingcap:master Apr 15, 2021
@ti-srebot
Copy link
Collaborator

cherry pick to release-4.0 in PR #1785

@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #1786

@leiysky leiysky deleted the fix/cast-time-as-int branch April 15, 2021 11:44
ti-srebot added a commit that referenced this pull request Apr 15, 2021
ti-srebot added a commit that referenced this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast datetime as int will return wrong value
3 participants