Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast time as int (#1760) #1786

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #1760 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1786

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/1786:release-5.0-7572e2026c85

Signed-off-by: Yu Lei [email protected]

What problem does this PR solve?

Issue Number: close #1759

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Release note

  • Fix problem that TiFlash coprocessor's cast time as int function may produce incorrect result.

@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Apr 15, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 15, 2021
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leiysky
Copy link
Contributor

leiysky commented Apr 15, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 1782

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 627b41a into pingcap:release-5.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants