Enable code format check for PR

[solotzg]

Signed-off-by: Zhigao Tong [email protected]

What problem does this PR solve?

Issue Number: close #2507 , related #2619

Problem Summary:

What is changed and how it works?

What's Changed:

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[solotzg]

After this PR, we should only use one code format style https://github.com/pingcap/tics/blob/master/.clang-format. If you have any proposal, please modify branch https://github.com/pingcap/tics/tree/format-check directly.

[JaySon-Huang]

After this PR, we should only use one code format style https://github.com/pingcap/tics/blob/master/.clang-format.

I think we should remove dbms/src/Storages/DeltaMerge/.clang-format, dbms/src/Storages/Page/.clang-format, dbms/src/Storages/Page/stable/.clang-format. Or editor (VS Code/vim) may format the files under those directories by those .clang-format files

[solotzg]

After this PR, we should only use one code format style https://github.com/pingcap/tics/blob/master/.clang-format.

I think we should remove dbms/src/Storages/DeltaMerge/.clang-format, dbms/src/Storages/Page/.clang-format, dbms/src/Storages/Page/stable/.clang-format. Or editor (VS Code/vim) may format the files under those directories by those .clang-format files

Can you help to delete those files in branch format-check?

[JaySon-Huang]

Could we add a git-commit-hook for formatting? It would be better than only check the format in CI.

[solotzg]

Could we add a git-commit-hook for formatting? It would be better than only check the format in CI.

I agree. But sometimes we still need to modify some places for testing or hacking. It's not friendly to check forcibly.

[JaySon-Huang]

Could we add a git-commit-hook for formatting? It would be better than only check the format in CI.

I agree. But sometimes we still need to modify some places for testing or hacking. It's not friendly to check forcibly.

Then we can provide a command in the README.md that developers could check the format before submitting PRs

[solotzg]

Can we merge this PR ？

[fuzhe1989]

LGTM

[JaySon-Huang]

LGTM

[solotzg]

@flowbehappy PTAL

[SchrodingerZhu]

/lgtm

[solotzg]

/merge

[ti-chi-bot]

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2e37f05