Use clang-format in tics

[fuzhe1989]

No description provided.

[jiaqizho]

can we add clang-format checking in git-hook?

[fuzhe1989]

@jiaqizho I were told that we already have a clang-format: https://github.com/pingcap/tics/blob/master/format.sh

What we need is a per-commit test set which will run after ci to ensure not slow down it. @solotzg do you have any plan about this?

[jiaqizho]

@jiaqizho I were told that we already have a clang-format: https://github.com/pingcap/tics/blob/master/format.sh

What we need is a per-commit test set which will run after ci to ensure not slow down it. @solotzg do you have any plan about this?

I known.

I mean add format.sh in git hook pre-commit. https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks

so before commit , it can check format and remind developers which files are not formatted.

[fuzhe1989]

@jiaqizho I'm not sure if it should block the merge. Anyway a pre-check is good, or at least we can manually use it to format in batch.

[solotzg]

https://github.com/pingcap/tics/blob/master/.clang-format This the format file in tics.
I usually use https://github.com/pingcap/tiflash/blob/master/storage/format-tics.py to format before committing.

[JaySon-Huang]

Maybe we should move the format-tics.py to the tics repo (and add a pre-check)?

[solotzg]

Maybe we can modify format-tics.py to check whether commits in PR are formated before running ci-build.

[solotzg]

Maybe we should move the format-tics.py to the tics repo (and add a pre-check)?

However, there are at least 3 kinds of .clang-format in tics repo. Shall we unify standards?

[fuzhe1989]

@solotzg let's do it :)