Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement format-diff #2535

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Implement format-diff #2535

merged 2 commits into from
Aug 2, 2021

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Aug 2, 2021

Signed-off-by: Zhigao Tong [email protected]

What problem does this PR solve?

Issue Number: about #2507

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • No release note

Signed-off-by: Zhigao Tong <[email protected]>
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot

This comment has been minimized.

@ti-srebot
Copy link
Collaborator

@fuzhe1989, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@solotzg
Copy link
Contributor Author

solotzg commented Aug 2, 2021

/run-all-tests

@solotzg solotzg merged commit 0c2fac3 into pingcap:master Aug 2, 2021
@solotzg solotzg deleted the format-diff branch August 2, 2021 04:19
@solotzg solotzg added needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 and removed needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 labels Aug 3, 2021
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.1 in PR #2545

ti-srebot added a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants