Support cast string as double push down (#2038) #2068
Conversation
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added
CHERRY-PICK
|
/rebuild |
|
/run-all-tests |
| @@ -4,7 +4,7 @@ | |||
| namespace DB | |||
| { | |||
|
|
|||
| StringRef trim(const StringRef & value) | |||
| String trim(const StringRef & value) | |||
There was a problem hiding this comment.
will it slow down the calculation? Is there anther way?
|
@LittleFall, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack). |
1 similar comment
|
@LittleFall, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack). |
|
@LittleFall, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack). |
cherry-pick #2038 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2068After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #1936
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note