Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cast string as double push down #2038

Merged
merged 7 commits into from
Jun 3, 2021
Merged

Support cast string as double push down #2038

merged 7 commits into from
Jun 3, 2021

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jun 1, 2021

What problem does this PR solve?

Issue Number: close #1936

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Support cast string as double push down

@leiysky leiysky added type/new-feature Issue or PR for new feature needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 component/expression labels Jun 1, 2021
leiysky added 5 commits June 3, 2021 14:43
@leiysky
support cast str as double (#1958)
3dbf42b
@leiysky
Fix cast string as double (#1966)
d6332bc 
* support cast str as double

* fix

* fix

* fix

* fix test

* refine

* add test

* update

* fix test
@leiysky
support cast str as double (#1958)
da30362
@leiysky
fix
8a91c7a
@leiysky
fix
d721058
@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/run-all-tests

@leiysky leiysky requested review from windtalker and fzhedu June 3, 2021 07:01
windtalker
windtalker approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2026
  • 2045
  • 2043
  • 2043
  • 2046

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@leiysky leiysky merged commit 65f3920 into pingcap:master Jun 3, 2021
@leiysky leiysky deleted the feature/cast-str-as-double branch June 3, 2021 09:22
@ti-srebot ti-srebot mentioned this pull request Jun 3, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2068

LittleFall pushed a commit that referenced this pull request Jun 17, 2021
@ti-srebot @leiysky
Support cast string as double push down (#2038) (#2068)
31d63d6 
* cherry pick #2038 to release-5.0

Signed-off-by: ti-srebot <[email protected]>

* fix conflict

Co-authored-by: Yu Lei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Issue or PR for new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support cast_str_as_double function push down
4 participants
@leiysky @ti-srebot @JaySon-Huang @windtalker