Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick bug fixes for PODArray (#1357) #1358

Merged

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jan 17, 2021

cherry-pick #1357 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1358

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/1358:release-4.0-eefb963d41bb

What problem does this PR solve?

Issue Number: maybe related to pingcap/tidb#22184

Problem Summary: TiFlash crashes when inserting data.

What is changed and how it works?

Cherry-pick two commits in Clickhouse to fix bugs for PODArray

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • Fix the bug that TiFlash may crash when reading data

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Jan 17, 2021
@ti-srebot ti-srebot added this to the v4.0.10 milestone Jan 17, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
@JaySon-Huang
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2021
@JaySon-Huang JaySon-Huang merged commit cf5be65 into pingcap:release-4.0 Jan 19, 2021
@JaySon-Huang JaySon-Huang deleted the release-4.0-eefb963d41bb branch January 19, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants