-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick bug fixes for PODArray #1357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
commented
Jan 15, 2021
/run-all-tests |
8798ee9
to
943426b
Compare
/run-all-tests |
flowbehappy
approved these changes
Jan 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-4.0 in PR #1358 |
lidezhu
pushed a commit
that referenced
this pull request
Jan 18, 2021
The stack frame of coredump is likely to be as following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-4.0
PR which needs to be cherry-picked to release-4.0
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: maybe related to pingcap/tidb#22184
Problem Summary: TiFlash crashes when inserting data.
What is changed and how it works?
Cherry-pick two commits in Clickhouse to fix bugs for PODArray
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note