Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cast decimal as string (#1256) #1281

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Fix cast decimal as string (#1256) #1281

merged 1 commit into from
Dec 13, 2020

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Dec 12, 2020 •
edited
Loading

Cherry picked from: #1256

What problem does this PR solve?

Issue Number: close #1255

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix wrong result of cast decimal as string in TiFlash coprocessor

@leiysky leiysky added CHERRY-PICK cherry pick type/bugfix This PR fixes a bug. labels Dec 12, 2020
@leiysky leiysky added this to the v4.0.9 milestone Dec 12, 2020
@leiysky leiysky self-assigned this Dec 12, 2020
@leiysky
Copy link
Contributor Author

leiysky commented Dec 12, 2020

/run-all-tests

1 similar comment
@leiysky
Copy link
Contributor Author

leiysky commented Dec 13, 2020

/run-all-tests

zanmato1984
zanmato1984 approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2020
@leiysky leiysky merged commit de0a49b into pingcap:release-4.0 Dec 13, 2020
@leiysky leiysky deleted the release-4.0 branch December 13, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@leiysky @zanmato1984 @ti-srebot