Fix cast decimal as string #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiysky
added
needs-cherry-pick-release-4.0
windtalker
reviewed
Dec 2, 2020
|
@windtalker PTAL |
|
/run-all-tests |
windtalker
reviewed
Dec 4, 2020
…ky/tics into fix/cast-decimal-as-string
|
/run-all-tests |
|
/run-all-tests |
|
@windtalker PTAL, again |
windtalker
reviewed
Dec 8, 2020
|
/run-all-tests |
…ky/tics into fix/cast-decimal-as-string
|
/run-all-tests |
windtalker
reviewed
Dec 8, 2020
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
…ky/tics into fix/cast-decimal-as-string
|
/run-all-tests |
|
/run-all-tests |
windtalker
reviewed
Dec 11, 2020
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 failed |
leiysky
commented
May 27, 2021
| @@ -101,7 +101,6 @@ struct TiDBConvertToString | |||
| auto col_to = ColumnString::create(); | |||
| ColumnString::Chars_t & data_to = col_to->getChars(); | |||
| ColumnString::Offsets & offsets_to = col_to->getOffsets(); | |||
| WriteBufferFromVector<ColumnString::Chars_t> write_buffer(data_to); | |||
There was a problem hiding this comment.
@LittleFall This part is related to #1998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1255
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Release note