Refactor storage configuration and strategies for choosing paths with multi-disks #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
JaySon-Huang
force-pushed
the
refine_choose_path
branch
from
6535e00 to
7fad2df
Compare
JaySon-Huang
changed the title
JaySon-Huang
force-pushed
the
refine_choose_path
branch
from
7fad2df to
4131247
Compare
JaySon-Huang
force-pushed
the
refine_choose_path
branch
from
4131247 to
0791d0c
Compare
|
/run-all-tests |
flowbehappy
reviewed
Nov 11, 2020
flowbehappy
reviewed
Nov 11, 2020
tests/docker/config/tiflash_dt.toml
Outdated
| default_profile = "default" | ||
| users_config = "users.toml" | ||
|
|
||
| # old style storage paths |
There was a problem hiding this comment.
Suggested change
| # old style storage paths | |
| # Deprecated path setting style. Check [storage] section for new style. |
flowbehappy
reviewed
Nov 11, 2020
tests/docker/config/tiflash_dt.toml
Outdated
|
|
||
| ## Store capacity of each path, i.e. max data size allowed. | ||
| ## If it is not set, or is set to 0s, disk capacity will be used. | ||
| # capacity = [ ] |
There was a problem hiding this comment.
Please also make an example.
flowbehappy
reviewed
Nov 11, 2020
tests/docker/config/tiflash_dt.toml
Outdated
| # dir = [ "/data0/tiflash", "/data1/tiflash" ] | ||
|
|
||
| ## Store capacity of each path, i.e. max data size allowed. | ||
| ## If it is not set, or is set to 0s, disk capacity will be used. |
There was a problem hiding this comment.
Suggested change
| ## If it is not set, or is set to 0s, disk capacity will be used. | |
| ## If it is not set, or is set to 0s, the actual disk capacity is used. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 15, 2020
JaySon-Huang
added a commit
that referenced
this pull request
Nov 15, 2020
* Support multi-disks for PageStorage (#1156) * Support multi-disks for RegionPersister (#1199) * Refactor storage configuration and strategies for choosing paths with multi-disks (#1216) Signed-off-by: JaySon-Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang [email protected]
What problem does this PR solve?
Issue Number: a part of #1128
Problem Summary:
Previously, we choose a path according to the used size inside one table. The global data distribution may be skew.
And if the capacities of different disks are not the same, the disk with a smaller capacity makes get full while other disks are available.
What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note