-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-disks for latest data #1156,#1199,#1216 #1159
Merged
JaySon-Huang
merged 4 commits into
pingcap:release-4.0
from
JaySon-Huang:refactor_path_pool_4.0
Nov 15, 2020
Merged
Support multi-disks for latest data #1156,#1199,#1216 #1159
JaySon-Huang
merged 4 commits into
pingcap:release-4.0
from
JaySon-Huang:refactor_path_pool_4.0
Nov 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
added
type/enhancement
The issue or PR belongs to an enhancement.
CHERRY-PICK
cherry pick
labels
Oct 19, 2020
/run-all-tests |
JaySon-Huang
changed the title
Support multi-paths for PageStorage #1156
[WIP] Support multi-paths for PageStorage #1156
Oct 23, 2020
/run-all-tests |
1 similar comment
/run-all-tests |
JaySon-Huang
force-pushed
the
refactor_path_pool_4.0
branch
from
October 26, 2020 11:16
5fcbc07
to
2a482cd
Compare
JaySon-Huang
changed the title
[WIP] Support multi-paths for PageStorage #1156
Support multi-paths for PageStorage #1156
Oct 27, 2020
JaySon-Huang
force-pushed
the
refactor_path_pool_4.0
branch
from
October 27, 2020 04:52
2a482cd
to
7d7ca45
Compare
JaySon-Huang
added
type/new-feature
Issue or PR for new feature
and removed
type/enhancement
The issue or PR belongs to an enhancement.
labels
Oct 27, 2020
JaySon-Huang
force-pushed
the
refactor_path_pool_4.0
branch
from
November 3, 2020 07:48
116acea
to
f4fc5df
Compare
flowbehappy
reviewed
Nov 3, 2020
JaySon-Huang
force-pushed
the
refactor_path_pool_4.0
branch
from
November 3, 2020 11:28
66491e0
to
02448c7
Compare
JaySon-Huang
changed the title
Support multi-paths for PageStorage #1156
Support multi-disks for PageStorage #1156
Nov 3, 2020
/run-all-tests |
flowbehappy
approved these changes
Nov 6, 2020
JaySon-Huang
force-pushed
the
refactor_path_pool_4.0
branch
from
November 15, 2020 10:29
02448c7
to
4861ad1
Compare
/run-all-tests |
/run-all-tests |
JaySon-Huang
changed the title
Support multi-disks for PageStorage #1156
Support multi-disks for latest data #1156
Nov 15, 2020
JaySon-Huang
changed the title
Support multi-disks for latest data #1156
Support multi-disks for latest data #1156,#1199,#1216
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CHERRY-PICK
cherry pick
status/LGT1
Indicates that a PR has LGTM 1.
type/new-feature
Issue or PR for new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick of #1156, #1199, #1216
What problem does this PR solve?
Issue Number: close #1128
Problem Summary: Currently, we can only use one path to store a PageStorage. It causes much more IO pressure(from Delta and Region snapshots) for the first disk than other disks when TiFlash is deployed in multi-paths mode. And support multi-paths for PageStorage can distribute the IO pressures between all disks.
What is changed and how it works?
Design doc:https://docs.google.com/document/d/1281wqqWNVj6LZMiWfcBPPQLOQN7w3koODPVLYWM6E68/edit#
PathPool
PathPool
: Only store the main_data_paths and latest_data_paths. GenerateStoragePathPool
for each storageStoragePathPool
: A class to manage paths for the specified storage*-Delegator
: Some delegator generated byStoragePathPool
. They are used for managing the path for storing stable/delta/raft dataPageStorage
andStorageDeltaMerge
to adapt to newPathPool
PathCapacityMetrics
for more detailsRelated changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note