Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider region pending status when dispatch task for disagg tiflash mode #7301

Closed
guo-shaoge opened this issue Apr 17, 2023 · 0 comments · Fixed by #7574
Closed

Consider region pending status when dispatch task for disagg tiflash mode #7301

guo-shaoge opened this issue Apr 17, 2023 · 0 comments · Fixed by #7574
Assignees
@guo-shaoge
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Apr 17, 2023 •
edited
Loading

Enhancement

For now, we didn't consider region status when dispatch MPPTask(tidb or tiflash_compute node). It may lead to MPPTask send to node whose region snapshot has not been synced from tikv, which make query to wait for a long time(aka wait index timeout, which is 10s).

So we need to consider region's pending status.

CN didn't consider region status at all:
cb1d65c7-c117-4d26-aeb4-945f025c14da

TiDB only consider down peer, didn't consider pending peer:
image
@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Apr 17, 2023
@guo-shaoge guo-shaoge changed the title Also need to consider region pending status when dispatch task for disagg tiflash mode Consider region pending status when dispatch task for disagg tiflash mode May 4, 2023
@guo-shaoge guo-shaoge self-assigned this May 4, 2023
This was referenced May 28, 2023
Open
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 31, 2023
@guo-shaoge
update client-c to support choosing non pending peer when dispatch ta…
d0f481c 
…sk (#7574)

close #7301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guo-shaoge guo-shaoge

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update client-c to support choosing non pending peer when dispatch task guo-shaoge/tiflash
1 participant
@guo-shaoge