ddl: set column collate from ColumnOptionCollate #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix ci. |
crazycs520
reviewed
Mar 29, 2019
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
314722b to
29eab84
Compare
Codecov Report
@@ Coverage Diff @@
## master #9947 +/- ##
================================================
+ Coverage 77.9622% 77.9929% +0.0307%
================================================
Files 407 407
Lines 83139 83096 -43
================================================
- Hits 64817 64809 -8
+ Misses 13521 13499 -22
+ Partials 4801 4788 -13 |
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
6914532 to
3005680
Compare
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
3005680 to
b080f16
Compare
winkyao
reviewed
Apr 15, 2019
|
/run-all-tests |
winkyao
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL
CREATE TABLEsyntax, column collation is part of the column option, so the following statements are valid(although meaningless):This PR makes those statements acceptable
What is changed and how it works?
In TiDB parser, Column "COLLATE" definitions are moved from 'StringType' to 'ColumnOption'(pingcap/parser#260)
This PR uses ColumnOptionCollate to set the collation of a column
Check List
Tests
Code changes
Side effects
Related changes