parser, ast: add ColumnOptionCollate for all column types #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkyao
reviewed
Mar 25, 2019
parser.y
Outdated
| $$ = &ast.ColumnDef{Name: $1.(*ast.ColumnName), Tp: $2.(*types.FieldType), Options: $3.([]*ast.ColumnOption)} | ||
| def := &ast.ColumnDef{Name: $1.(*ast.ColumnName), Tp: $2.(*types.FieldType)} | ||
| opts := make([]*ast.ColumnOption, 0) | ||
| for _, opt := range $3.([]*ast.ColumnOption) { |
There was a problem hiding this comment.
Move this logic to CreateTable?
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
4b60e72 to
4990418
Compare
crazycs520
reviewed
Mar 29, 2019
| @@ -416,6 +418,12 @@ func (n *ColumnOption) Restore(ctx *RestoreCtx) error { | |||
| if err := n.Refer.Restore(ctx); err != nil { | |||
| return errors.Annotate(err, "An error occurred while splicing ColumnOption ReferenceDef") | |||
| } | |||
| case ColumnOptionCollate: | |||
There was a problem hiding this comment.
Please add test in TestDDL for testing restore.
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
37794c8 to
f5a0676
Compare
|
Please fix the conflict. |
bb7133
force-pushed
the
bb7133/parser_collate
branch
from
f5a0676 to
09b4eea
Compare
|
Updated, thanks @zimulala |
winkyao
approved these changes
Apr 4, 2019
bb7133
added a commit
to bb7133/parser
that referenced
this pull request
Apr 16, 2019
bb7133
added a commit
that referenced
this pull request
Apr 17, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL
CREATE TABLEsyntax, column collation is part of the column option, so the following statements are valid(although meaningless):This PR makes those statements acceptable
What is changed and how it works?
Column "COLLATE" definitions are moved from 'StringType' to 'ColumnOption'
Check List
Tests
Code changes
Side effects
Related changes