Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: get right max table id when to init stats (#58280) #58298

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58280

What problem does this PR solve?

Issue Number: close #58284
Problem Summary:

What changed and how does it work?

when we get max table id, we should save it into atomic value. but we save common table id into it. so it is bad max table id and lead to other problem .

Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

get right max table id when to init stats

修复在 init stats 阶段,得到正确的加载范围

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@7ce96f9). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58298   +/-   ##
================================================
  Coverage               ?   56.9217%           
================================================
  Files                  ?       1773           
  Lines                  ?     627054           
  Branches               ?          0           
================================================
  Hits                   ?     356930           
  Misses                 ?     245936           
  Partials               ?      24188           
Flag Coverage Δ
integration 36.8285% <8.3333%> (?)
unit 72.5739% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2793% <0.0000%> (?)

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei requested a review from AilinKid December 16, 2024 11:10
Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 10:27:06.341724493 +0000 UTC m=+866216.430527050: ☑️ agreed by hawkingrei.
  • 2024-12-16 14:17:19.953522301 +0000 UTC m=+880030.042324843: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 678b713 into pingcap:release-8.5 Dec 16, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-58280-to-release-8.5 branch December 17, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants