Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: get right max table id when to init stats #58280

Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 16, 2024

What problem does this PR solve?

Issue Number: close #58284
Problem Summary:

What changed and how does it work?

when we get max table id, we should save it into atomic value. but we save common table id into it. so it is bad max table id and lead to other problem .

Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

get right max table id when to init stats

修复在 init stats 阶段,得到正确的加载范围

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8973%. Comparing base (cc83417) to head (eeaaab8).
Report is 36 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58280        +/-   ##
================================================
+ Coverage   73.2296%   73.8973%   +0.6677%     
================================================
  Files          1675       1705        +30     
  Lines        462254     470328      +8074     
================================================
+ Hits         338507     347560      +9053     
+ Misses       102970     101280      -1690     
- Partials      20777      21488       +711     
Flag Coverage Δ
integration 46.0207% <0.0000%> (?)
unit 72.3793% <100.0000%> (+0.0185%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9809% <ø> (-0.0061%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
Copy link

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 06:47:46.580658858 +0000 UTC m=+853056.669461398: ☑️ agreed by AilinKid.
  • 2024-12-16 06:55:29.858004636 +0000 UTC m=+853519.946807178: ☑️ agreed by qw4990.

@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the get_right_value_get_max_table_id branch from 145de7f to eeaaab8 Compare December 16, 2024 08:54
@ti-chi-bot ti-chi-bot bot merged commit 9823f00 into pingcap:master Dec 16, 2024
25 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #58296.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #58297.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 16, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 16, 2024
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #58298.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot get right max table id when to init stats
4 participants