-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix the issue that DROP TABLE
/ ALTER TABLE
will keep job running (#57707)
#57827
ttl: fix the issue that DROP TABLE
/ ALTER TABLE
will keep job running (#57707)
#57827
Conversation
Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57827 +/- ##
================================================
Coverage ? 58.0571%
================================================
Files ? 1774
Lines ? 638736
Branches ? 0
================================================
Hits ? 370832
Misses ? 243870
Partials ? 24034
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #57707
What problem does this PR solve?
Issue Number: close #57556, close #57702
Problem Summary:
If the TTL job owner restarts and the TTL table is disabled or dropped, it'll not be removed and will always keep running.
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.