Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: fix the issue that DROP TABLE / ALTER TABLE will keep job running (#57707) #57827

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57707

What problem does this PR solve?

Issue Number: close #57556, close #57702

Problem Summary:

If the TTL job owner restarts and the TTL table is disabled or dropped, it'll not be removed and will always keep running.

What changed and how does it work?

  1. Also remove the table even when it's current status is not NULL if its heartbeat has timeout.
  2. Shorten the GC period to 10 minutes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@43b21d4). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57827   +/-   ##
================================================
  Coverage               ?   58.0571%           
================================================
  Files                  ?       1774           
  Lines                  ?     638736           
  Branches               ?          0           
================================================
  Hits                   ?     370832           
  Misses                 ?     243870           
  Partials               ?      24034           
Flag Coverage Δ
integration 37.5884% <0.0000%> (?)
unit 73.8240% <77.7777%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.2477% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 51.9806% <0.0000%> (?)

@YangKeao
Copy link
Member

YangKeao commented Jan 6, 2025

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 6, 2025
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 09:29:31.636757335 +0000 UTC m=+173114.925589042: ☑️ agreed by lcwangchao.
  • 2025-01-07 06:03:31.778200931 +0000 UTC m=+247155.067032634: ☑️ agreed by YangKeao.

@YangKeao
Copy link
Member

YangKeao commented Jan 7, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5f4b16d into pingcap:release-8.5 Jan 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants