Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump client-go with some regression tests #57282

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

you06
Copy link
Contributor

@you06 you06 commented Nov 11, 2024

What problem does this PR solve?

Issue Number: ref #55287, close #56837, ref #57338, close #57425

Problem Summary:

What changed and how does it work?

Introduce the chunk comparison of common prefix (amd64 and arm64 only), which can accelerate a lot for indexes with very wide columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
Copy link

tiprow bot commented Nov 11, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1365%. Comparing base (a22b842) to head (b58330a).
Report is 88 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57282        +/-   ##
================================================
+ Coverage   72.8488%   73.1365%   +0.2876%     
================================================
  Files          1672       1676         +4     
  Lines        462666     471279      +8613     
================================================
+ Hits         337047     344677      +7630     
- Misses       104821     105657       +836     
- Partials      20798      20945       +147     
Flag Coverage Δ
integration 43.5259% <86.3636%> (?)
unit 72.2152% <100.0000%> (-0.0065%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 43.2710% <ø> (-1.8516%) ⬇️

wshwsh12 and others added 2 commits November 18, 2024 16:35
ref pingcap#53127

handle key-too-large error from MemBuffer

Signed-off-by: you06 <[email protected]>

test MemBuffer's oversize error to tidb error

Signed-off-by: you06 <[email protected]>

update errdoc

Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the client-go/art-opt branch from 02c96c9 to 2e79a1a Compare November 18, 2024 07:46
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2024
@you06 you06 changed the title *: bump client-go to improve the performance of ART *: bump client-go with some regression tests Nov 18, 2024
@you06 you06 requested review from cfzjywxk and ekexium November 18, 2024 07:50
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ekexium ekexium linked an issue Nov 19, 2024 that may be closed by this pull request
@you06
Copy link
Contributor Author

you06 commented Nov 20, 2024

/retest

Copy link

tiprow bot commented Nov 20, 2024

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/executor/mem_reader.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 08:10:37.684484498 +0000 UTC m=+862199.875353492: ☑️ agreed by ekexium.
  • 2024-11-20 05:19:22.527742454 +0000 UTC m=+8950.147396966: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 20, 2024
@you06
Copy link
Contributor Author

you06 commented Nov 20, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit e234164 into pingcap:master Nov 20, 2024
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57563.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@you06 you06 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 27, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #57761.

you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
Signed-off-by: ti-chi-bot <[email protected]>

resolve conflict

Signed-off-by: you06 <[email protected]>

fix pr

Signed-off-by: you06 <[email protected]>
@you06 you06 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #57763.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57764.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57765.

you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
Signed-off-by: ti-chi-bot <[email protected]>

resolve conflict

Signed-off-by: you06 <[email protected]>

fix pr

Signed-off-by: you06 <[email protected]>
you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
Signed-off-by: you06 <[email protected]>
you06 added a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
Signed-off-by: you06 <[email protected]>
you06 added a commit to ti-chi-bot/tidb that referenced this pull request Dec 5, 2024
Signed-off-by: you06 <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
5 participants