Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tipb and kvproto to use unified protobuf code #57338

Closed
overvenus opened this issue Nov 13, 2024 · 0 comments · Fixed by #57424
Closed

Update tipb and kvproto to use unified protobuf code #57338

overvenus opened this issue Nov 13, 2024 · 0 comments · Fixed by #57424
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@overvenus
Copy link
Member

Enhancement

Recently, tipb and kvproto have unified their protobuf generation options, and reduced bloated code by removing unused fields.

To update them, TiDB need to clean these paddings 1

tidb/pkg/kv/key.go

Lines 102 to 104 in 5129bb3

XXXNoUnkeyedLiteral struct{}
XXXunrecognized []byte
XXXsizecache int32

CC pingcap/kvproto#1278
CC pingcap/tipb#347

Footnotes

  1. https://github.com/pingcap/kvproto/pull/1275#pullrequestreview-2431765868 ↩
@overvenus overvenus added the type/enhancement The issue or PR belongs to an enhancement. label Nov 13, 2024
This was referenced Nov 13, 2024
Merged
Merged
Merged
Merged
@you06 you06 mentioned this issue Nov 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 20, 2024
@you06
*: bump client-go with some regression tests (#57282)
e234164 
ref #55287, close #56837, ref #57338, close #57425
@ti-chi-bot ti-chi-bot mentioned this issue Nov 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 21, 2024
@ti-chi-bot
*: bump client-go with some regression tests (#57282) (#57563)
9862e83 
ref #55287, close #56837, ref #57338, close #57425
ti-chi-bot bot pushed a commit that referenced this issue Nov 21, 2024
@overvenus
*: update tipb and remove unused fields (#57424)
9ae814b 
close #57338
ti-chi-bot bot pushed a commit to tikv/pd that referenced this issue Nov 22, 2024
@overvenus
*: update kvproto (#8816)
2917d45 
ref #4399, ref pingcap/tidb#57338

Signed-off-by: Neil Shen <[email protected]>
This was referenced Nov 27, 2024
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 5, 2024
@ti-chi-bot
*: bump client-go with some regression tests (#57282) (#57763)
858ba74 
ref #55287, close #56837, ref #57338, close #57425
ti-chi-bot bot pushed a commit that referenced this issue Dec 5, 2024
@ti-chi-bot
*: bump client-go with some regression tests (#57282) (#57761)
bc456c1 
ref #55287, close #56837, ref #57338, close #57425
ti-chi-bot bot pushed a commit that referenced this issue Dec 5, 2024
@ti-chi-bot
*: bump client-go with some regression tests (#57282) (#57765)
4b4b177 
ref #55287, close #56837, ref #57338, close #57425
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2024
@ti-chi-bot
*: bump client-go with some regression tests (#57282) (#57764)
6722c39 
ref #55287, close #56837, ref #57338, close #57425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update tipb and remove unused fields overvenus/tidb
1 participant
@overvenus