-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: runWithSystemSession
also copy snapshot status (#54989)
#56907
executor: runWithSystemSession
also copy snapshot status (#54989)
#56907
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold wait #56902 |
…k-54989-to-release-7.1 Signed-off-by: lance6716 <[email protected]>
/unhold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #56907 +/- ##
================================================
Coverage ? 73.4435%
================================================
Files ? 1212
Lines ? 380879
Branches ? 0
================================================
Hits ? 279731
Misses ? 83279
Partials ? 17869 |
This is an automated cherry-pick of #54989
What problem does this PR solve?
Issue Number: close #54964
Problem Summary:
What changed and how does it work?
introduced by #54791 . I'm not sure we should copy more status from user session to system session
Check List
Tests
manually tested the steps in #54964 (comment) . It's strange that real tikv tests can't reproduce
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.