executor: runWithSystemSession also copy snapshot status

[lance6716]

What problem does this PR solve?

Issue Number: close #54964

Problem Summary:

What changed and how does it work?

introduced by #54791 . I'm not sure we should copy more status from user session to system session

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

manually tested the steps in #54964 (comment) . It's strange that real tikv tests can't reproduce

mysql> use test
Database changed
mysql> create table t(c int);
Query OK, 0 rows affected (0.05 sec)

mysql> create view v as select * from t;
Query OK, 0 rows affected (0.04 sec)

mysql> set @@tidb_snapshot = NOW();
Query OK, 0 rows affected (0.01 sec)

mysql> begin;
Query OK, 0 rows affected (0.00 sec)

mysql> show columns in v;
+-------+---------+------+------+---------+-------+
| Field | Type    | Null | Key  | Default | Extra |
+-------+---------+------+------+---------+-------+
| c     | int(11) | YES  |      | NULL    |       |
+-------+---------+------+------+---------+-------+
1 row in set (0.00 sec)

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/check-issue-triage-complete

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.8663%. Comparing base (7cdf918) to head (36ea038).
Report is 678 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54989        +/-   ##
================================================
+ Coverage   72.8418%   74.8663%   +2.0244%     
================================================
  Files          1560       1563         +3     
  Lines        438616     443234      +4618     
================================================
+ Hits         319496     331833     +12337     
+ Misses        99538      91245      -8293     
- Partials      19582      20156       +574     

Flag	Coverage Δ
integration	49.7093% <66.6666%> (?)
unit	71.8484% <66.6666%> (+0.0032%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5722% <ø> (+6.6931%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-29 08:17:15.80339242 +0000 UTC m=+170952.083440487: ☑️ agreed by D3Hunter.
• 2024-07-29 09:03:16.965101068 +0000 UTC m=+173713.245149140: ☑️ agreed by tangenta.

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/cherry-pick release-7.5

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #55028.

[ti-chi-bot]

@lance6716: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-54989-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-54989-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lance6716]

/cherry-pick release-8.1

[ti-chi-bot]

@lance6716: new pull request created to branch release-8.1: #55048.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #55644.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56907.