Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: avoid wrong warning #56492

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 9, 2024

What problem does this PR solve?

Issue Number: close #55902

Problem Summary:
the wrong warning log is print after backup done.

What changed and how does it work?

don't print the wrong warning log.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 9, 2024
Copy link

tiprow bot commented Oct 9, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.7252%. Comparing base (df821b9) to head (863231b).
Report is 436 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56492         +/-   ##
=================================================
- Coverage   73.2357%   57.7252%   -15.5105%     
=================================================
  Files          1626       1773        +147     
  Lines        448692     645492     +196800     
=================================================
+ Hits         328603     372612      +44009     
- Misses        99977     247953     +147976     
- Partials      20112      24927       +4815     
Flag Coverage Δ
integration 40.2763% <0.0000%> (?)
unit 72.8887% <100.0000%> (+0.4486%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 64.0504% <100.0000%> (+18.5789%) ⬆️

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 10, 2024

/retest

Copy link

tiprow bot commented Oct 10, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 06:11:09.97046209 +0000 UTC m=+1112825.390675099: ☑️ agreed by 3pointer.
  • 2024-10-10 06:12:27.631817619 +0000 UTC m=+1112903.052030628: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 10, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 10, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 10, 2024

/retest

2 similar comments
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 11, 2024

/retest

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 56be6bb into pingcap:master Oct 11, 2024
38 of 52 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 31, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57033.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 31, 2024
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57888.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2024
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #57985.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 4, 2024
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup always print the warning log
5 participants