Skip to content

Commit

Permalink
br: avoid wrong warning (#56492) (#57985)
Browse files Browse the repository at this point in the history
close #55902
  • Loading branch information
ti-chi-bot authored Dec 12, 2024
1 parent 48962ce commit 7959487
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion br/pkg/utils/safe_point.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func UpdateServiceSafePoint(ctx context.Context, pdClient pd.Client, sp BRServic
log.Debug("update PD safePoint limit with TTL", zap.Object("safePoint", sp))

lastSafePoint, err := pdClient.UpdateServiceGCSafePoint(ctx, sp.ID, sp.TTL, sp.BackupTS-1)
if lastSafePoint > sp.BackupTS-1 {
if lastSafePoint > sp.BackupTS-1 && sp.TTL > 0 {
log.Warn("service GC safe point lost, we may fail to back up if GC lifetime isn't long enough",
zap.Uint64("lastSafePoint", lastSafePoint),
zap.Object("safePoint", sp),
Expand Down

0 comments on commit 7959487

Please sign in to comment.