Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix checkpoint path #55266

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Aug 7, 2024

What problem does this PR solve?

Issue Number: close #55265

Problem Summary:
WalkDir the path {bucket}/{prefix}//{sub-dir} get the object {bucket}/{prefix}//{sub-dir}/object, but ReadFile the object {bucket}/{prefix}//{sub-dir}/object cannot find it.

What changed and how does it work?

/checkpoints -> checkpoints

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 7, 2024
Copy link

tiprow bot commented Aug 7, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-07 09:12:07.807151915 +0000 UTC m=+429657.674251003: ☑️ agreed by YuJuncen.
  • 2024-08-07 09:20:00.048907733 +0000 UTC m=+430129.916006820: ☑️ agreed by 3pointer.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2474%. Comparing base (3117d3f) to head (d3b997d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55266        +/-   ##
================================================
+ Coverage   74.7769%   75.2474%   +0.4705%     
================================================
  Files          1572       1572                
  Lines        364757     441413     +76656     
================================================
+ Hits         272754     332152     +59398     
- Misses        72233      88564     +16331     
- Partials      19770      20697       +927     
Flag Coverage Δ
integration 49.6211% <ø> (?)
unit 71.8302% <ø> (-1.8751%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 62.3001% <ø> (+14.6296%) ⬆️

@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 7, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 7, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 7, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2ce3cdb into pingcap:master Aug 7, 2024
35 of 40 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 8, 2024
@Leavrth Leavrth added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Aug 8, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 8, 2024
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55295.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55296.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 8, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 8, 2024
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55297.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55298.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 30, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 25, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br checkpoint is not compatible with some external storage.
4 participants