-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Regenerating AutoIDs for _tidb_rowid during Reorganize Partition (#53770) #54560
ddl: Regenerating AutoIDs for _tidb_rowid during Reorganize Partition (#53770) #54560
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yang Keao <[email protected]>
f595a8a
to
76899a6
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54560 +/- ##
================================================
Coverage ? 72.0566%
================================================
Files ? 1412
Lines ? 411143
Branches ? 0
================================================
Hits ? 296256
Misses ? 95010
Partials ? 19877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #53770
What problem does this PR solve?
When EXCHANGE PARTITION is used, the _tidb_rowid from the exchanged table, may conflict with rows in other partitions, which can collide during REORGANIZE PARTITION or REMOVE PARTITIONING since they keep the _tidb_rowid but will be placed in the same physical partition/table.
Solution:
Generate new _tidb_rowid for each row during the data reorganization phase.
Issue Number: close #53385
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.