ddl: Regenerating AutoIDs for _tidb_rowid during Reorganize Partition

[mjonss]

What problem does this PR solve?

When EXCHANGE PARTITION is used, the _tidb_rowid from the exchanged table, may conflict with rows in other partitions, which can collide during REORGANIZE PARTITION or REMOVE PARTITIONING since they keep the _tidb_rowid but will be placed in the same physical partition/table.

Solution:
Generate new _tidb_rowid for each row during the data reorganization phase.

Issue Number: close #53385

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.8548%. Comparing base (f1ec74b) to head (8d944e6).
Report is 45 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53770         +/-   ##
=================================================
- Coverage   74.4865%   55.8548%   -18.6317%     
=================================================
  Files          1506       1629        +123     
  Lines        357921     606377     +248456     
=================================================
+ Hits         266603     338691      +72088     
- Misses        71922     244504     +172582     
- Partials      19396      23182       +3786     

Flag	Coverage Δ
integration	37.1762% <55.0000%> (?)
unit	71.4456% <55.0000%> (-1.9152%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-2.2339%)	⬇️
parser	∅ <ø> (∅)
br	49.7779% <ø> (+6.2239%)	⬆️

[Defined2014]

I'm not sure, will this cause data races between different reorg workers?

[mjonss]

I think each worker w should have its own context and session vars, and which will be used as a cache for the worker, and get globally allocated ids from tables.AllocHandleIDs() which is protected by a lock.

Anyway to verify/test this?

[zimulala]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,zimulala]
• pkg/ddl/OWNERS [zimulala]
• pkg/table/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-11 02:58:48.670616278 +0000 UTC m=+433482.723928202: ☑️ agreed by Defined2014.
• 2024-06-13 03:22:30.584960235 +0000 UTC m=+607704.638272154: ☑️ agreed by zimulala.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #54560.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55052.