-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: make the transaction from initStatsCtx
blocking gc (#53602)
#53638
domain: make the transaction from initStatsCtx
blocking gc (#53602)
#53638
Conversation
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53638 +/- ##
================================================
Coverage ? 72.8458%
================================================
Files ? 1465
Lines ? 437174
Branches ? 0
================================================
Hits ? 318463
Misses ? 98378
Partials ? 20333
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@hawkingrei @lance6716 PTAL |
/approve |
[LGTM Timeline notifier]Timeline:
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520, lance6716, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #53602
What problem does this PR solve?
Issue Number: close #53592
Problem Summary:
The
initStatsCtx
is not get from internal session pool, so it's not tracked by min start ts service, thus gc lifetime can overtake it easily.What changed and how does it work?
Insert it into tracked session table and it will block gc.
Check List
Tests
I reproduce the test mentioned in issue, the stats are loaded successfully after 30min.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.