-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: make the transaction from initStatsCtx
blocking gc
#53602
Conversation
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Skipping CI for Draft Pull Request. |
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
initStatsCtx
blocking gcinitStatsCtx
blocking gc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53602 +/- ##
================================================
+ Coverage 72.6008% 74.8736% +2.2728%
================================================
Files 1505 1507 +2
Lines 429827 439654 +9827
================================================
+ Hits 312058 329185 +17127
+ Misses 98576 90253 -8323
- Partials 19193 20216 +1023
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: you06 <[email protected]>
/retest-required |
@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: you06 <[email protected]>
/retest |
@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]> resolve conflict Signed-off-by: you06 <[email protected]> bazel Signed-off-by: you06 <[email protected]> fix failpoint Signed-off-by: you06 <[email protected]>
What problem does this PR solve?
Issue Number: close #53592
Problem Summary:
The
initStatsCtx
is not get from internal session pool, so it's not tracked by min start ts service, thus gc lifetime can overtake it easily.What changed and how does it work?
Insert it into tracked session table and it will block gc.
Check List
Tests
I reproduce the test mentioned in issue, the stats are loaded successfully after 30min.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.