Add more column schema change tests. #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Now we can add more error test now :-) |
|
Aggreed, i will do it later. |
qiuyesuifeng
added a commit
that referenced
this pull request
Nov 6, 2015
Add more column schema change tests.
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* update tidb6.6: userprefix (pingcap#221) * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * add get user with prefix (pingcap#176) Signed-off-by: David <[email protected]> Signed-off-by: David <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * remove log Signed-off-by: zeminzhou <[email protected]> * remove tidb verion related codoes Signed-off-by: zeminzhou <[email protected]> * remove get keyspace from env Signed-off-by: zeminzhou <[email protected]> * revert keyspace.go Signed-off-by: zeminzhou <[email protected]> * keyspace2 -> keyspace Signed-off-by: zeminzhou <[email protected]> * revert util/sem/sem.go Signed-off-by: zeminzhou <[email protected]> * Update domain/user_prefix.go Co-authored-by: David <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> * update tidb6.6: userprefix (pingcap#221) * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * add get user with prefix (pingcap#176) Signed-off-by: David <[email protected]> Signed-off-by: David <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * remove log Signed-off-by: zeminzhou <[email protected]> * remove tidb verion related codoes Signed-off-by: zeminzhou <[email protected]> * remove get keyspace from env Signed-off-by: zeminzhou <[email protected]> * revert keyspace.go Signed-off-by: zeminzhou <[email protected]> * keyspace2 -> keyspace Signed-off-by: zeminzhou <[email protected]> * revert util/sem/sem.go Signed-off-by: zeminzhou <[email protected]> * Update domain/user_prefix.go Co-authored-by: David <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> * [DNM] change cloud_admin user to prefix.cloud_admin (pingcap#399) * change cloud_admin user to prefix.cloud_admin, update to serverlessVersion15 * use UPDATE sql * validate user prefix when rename user * forbidden rename user cloud_admin * UPDATE mysql.global_priv, mysql.global_grants * remove domain.GetUserPrefix() * fix .bazel * fix RenameUserStmt, return nil * fix conflict * fix cloud_admin user (pingcap#448) * make check Signed-off-by: zeminzhou <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: better0332 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@siddontang PTAL