*: Add replace statement #448

zimulala · 2015-10-24T08:28:14Z

siddontang · 2015-10-24T10:23:32Z

parser/parser.y

+		x.TableIdent = $4.(table.Ident)
+		$$ = x
+		if yylex.(*lexer).root {
+			break


can we remove this break? seem strange for insert and replace.

siddontang · 2015-10-26T08:17:01Z

parser/parser.y

+ReplaceIntoStmt:
+	"REPLACE" ReplacePriority IntoOpt TableIdent InsertRest
+	{
+		x := &stmts.ReplaceIntoStmt{ColNames: $5.(*stmts.InsertIntoStmt).ColNames, 


extract ColNames, Lists, etc... to a base struct, for ReplaceIntoStmt and InsertIntoStmt use, not use InsertIntoStmt directly.

to make the code more clear

zimulala · 2015-10-26T10:44:18Z

PTAL @siddontang , @shenli , @qiuyesuifeng

siddontang · 2015-10-26T10:46:28Z

LGTM

zimulala · 2015-10-27T02:34:47Z

PTAL @qiuyesuifeng

qiuyesuifeng · 2015-10-27T02:51:04Z

stmt/stmts/insert.go

@@ -46,15 +46,20 @@ const (
 	DelayedPriority
 )

+// InsertRest is the rest part of insert/replace into statement.
+type InsertRest struct {


I prefer remove InsertRest to rsets package, maybe this or next PR.
@siddontang How about u?

The InsertRset is very close to Insert and replace and can't be moved to rset package, maybe, so let it here now.
btw, InsertRest -> InsertRset @zimulala

but the name in the parser.y is InsertRest,
modify all？

zimulala · 2015-10-27T05:28:00Z

PTAL @qiuyesuifeng

qiuyesuifeng · 2015-10-27T09:29:39Z

LGTM

*: Add replace statement

…cap#448) * fix gc ttl loop * resolve comment and add tests

* save my work add notes save work save work fix unit test remove tidbMgr in RestoreController remove some comments remove some comments change logger in SQLWithRetry revert replace log.Logger to *zap.Logger dep: update uuid dependency to latest google/uuid (pingcap#452) * dep: update satori/go.uuid to latest * fix tests * change to google/uuid * fix build * try fix test * get familiar with google/uuid * address comment tidb-lightning-ctl: change default of -d to 'noop://' (pingcap#453) also add noop:// to supported storage types (to represent an empty store) replace tab to space try another port to fix CI remove some comment *: more glue restore: fix the bug that gc life time ttl does not take effect (pingcap#448) * fix gc ttl loop * resolve comment and add tests fix CI report info to host TiDB config: filter out all system schemas by default (pingcap#459) backend: fix auto random default value for primary key (pingcap#457) * fix auto generate auto random primary key column * fix default for auto random primary key * fix test * use prev row id for auto random and add a test * replace chunck with session opt * fix * fix mydumper: fix parquet data parser (pingcap#435) * fix parquet * reorder imports * fix test * use empty collation * fix a error and add more test cases * add pointer type tests * resolve comments Co-authored-by: kennytm <[email protected]> address comment backend/local: use range properties to optimize region range estimate (pingcap#422) * use range propreties to estimate region range * post-restore: add optional level for post-restore operations (pingcap#421) * add optional level for opst-restore operations * trim leading and suffix '" * use UnmarshalTOML to unmarshal post restore op level * resolve comments and fix unit test * backend/local: do not retry epochNotMatch error when ingest sst (pingcap#419) * do not retry epochNotMatch error when ingest sst * add retry ingest for 'Raft raft: proposal dropped' error in ingest * change some retryable error log level from Error to Warn * fix nextKey * add a comment for nextKey * fix comment and add a unit test * wrap time.Sleep in select Co-authored-by: kennytm <[email protected]> * update * use range properties to optimze region range estimate * update pebble * change the default value for batch-size * add unit tests and reslove comments * add a comment to range properties test * add a comment * add a test for range property with pebble * rename const variable Co-authored-by: kennytm <[email protected]> fix pd service id is empty (pingcap#460) fix s3 parquet reader (pingcap#461) Co-authored-by: Neil Shen <[email protected]> fix service gc ttl again (pingcap#465) address comment mydumper: verify file routing config (pingcap#470) * fix file routing * remove useless line * remove redundant if check rename a method in interface save work try fix CI could work change ctx usage try fix CI try fix CI refine function interface refine some fucntion interface debug CI address comment config: allow four byte-size config to be specified using human-readable units ("100 GiB") (pingcap#471) * Makefile: add `make finish-prepare` action * config: accept human-readable size for most byte-related config e.g. allow `region-split-size = '96M'` in additional to `= 100663296` (known issue: these values' precisions will be truncated to 53 bits instead of supporting all 63 bits) * restore: reduce chance of spurious errors from TestGcTTLManagerSingle Co-authored-by: glorv <[email protected]> remove debug log test: change double type syntax (pingcap#474) address comment checkpoint: add glue checkpoint resolve cycle import expose Retry refine change interface to cope with TiDB fix SQL string fix SQL adjust interface to embedded in TiDB could import now reduce TLS restore: add `glue.Glue` interface and other function (pingcap#456) * save my work * add notes * save work * save work * fix unit test * remove tidbMgr in RestoreController * remove some comments * remove some comments * change logger in SQLWithRetry * revert replace log.Logger to *zap.Logger * replace tab to space * try another port to fix CI * remove some comment * *: more glue * report info to host TiDB * fix CI * address comment * address comment * rename a method in interface * save work * try fix CI * could work * change ctx usage * try fix CI * try fix CI * refine function interface * refine some fucntion interface * debug CI * address comment * remove debug log * address comment modify code add comment refine some code * address comment * add some comments * fix CI and change CREATE TABLE

* update tidb6.6: userprefix (pingcap#221) * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * add get user with prefix (pingcap#176) Signed-off-by: David <[email protected]> Signed-off-by: David <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * remove log Signed-off-by: zeminzhou <[email protected]> * remove tidb verion related codoes Signed-off-by: zeminzhou <[email protected]> * remove get keyspace from env Signed-off-by: zeminzhou <[email protected]> * revert keyspace.go Signed-off-by: zeminzhou <[email protected]> * keyspace2 -> keyspace Signed-off-by: zeminzhou <[email protected]> * revert util/sem/sem.go Signed-off-by: zeminzhou <[email protected]> * Update domain/user_prefix.go Co-authored-by: David <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> * update tidb6.6: userprefix (pingcap#221) * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * add get user with prefix (pingcap#176) Signed-off-by: David <[email protected]> Signed-off-by: David <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * userprefix & tidb version Signed-off-by: zeminzhou <[email protected]> * remove log Signed-off-by: zeminzhou <[email protected]> * remove tidb verion related codoes Signed-off-by: zeminzhou <[email protected]> * remove get keyspace from env Signed-off-by: zeminzhou <[email protected]> * revert keyspace.go Signed-off-by: zeminzhou <[email protected]> * keyspace2 -> keyspace Signed-off-by: zeminzhou <[email protected]> * revert util/sem/sem.go Signed-off-by: zeminzhou <[email protected]> * Update domain/user_prefix.go Co-authored-by: David <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> * [DNM] change cloud_admin user to prefix.cloud_admin (pingcap#399) * change cloud_admin user to prefix.cloud_admin, update to serverlessVersion15 * use UPDATE sql * validate user prefix when rename user * forbidden rename user cloud_admin * UPDATE mysql.global_priv, mysql.global_grants * remove domain.GetUserPrefix() * fix .bazel * fix RenameUserStmt, return nil * fix conflict * fix cloud_admin user (pingcap#448) * make check Signed-off-by: zeminzhou <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: David <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: better0332 <[email protected]>

zimulala added 11 commits October 22, 2015 14:43

parser: add parse replace statment

e26875e

parser: add test of parsing replace statment

5e9042b

stmt: add replace statment

3447ac2

stmt: add replace statment test

c5cb36a

stmt: adjust the code format

b9f0bbe

stmt: rename addRecord to getRow

79ecef3

stmt: add removeExistRow

84ae608

stmt: add replace primary key and unique index test

ccc0ffd

stmt: rename addRecord to getRow and rename SetList to Setlist

36a6080

stmt: change remove method to function

bacb489

stmt: update affected rows and test

b4562dc

siddontang reviewed Oct 24, 2015
View reviewed changes

*: Update format.

f5f4b22

siddontang reviewed Oct 26, 2015
View reviewed changes

*: rename getSetlist to fillValueList and add the InsertRest structure

5a42db1

to make the code more clear

stmt: update only modify columns.

376bdee

qiuyesuifeng reviewed Oct 27, 2015
View reviewed changes

*: rename InsertRest to InsertValues and add TODOs

4f92173

zimulala added a commit that referenced this pull request Oct 27, 2015

Merge pull request #448 from pingcap/zimuxia/replace

3ce3925

*: Add replace statement

zimulala merged commit 3ce3925 into master Oct 27, 2015

zimulala deleted the zimuxia/replace branch October 29, 2015 01:37

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021

brieSQL: fix multi-thread panic during SQL restore (pingcap#448)

6455c47

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021

restore: fix the bug that gc life time ttl does not take effect (ping…

25a3711

…cap#448) * fix gc ttl loop * resolve comment and add tests

nolouch pushed a commit to nolouch/tidb that referenced this pull request Jul 13, 2023

fix cloud_admin user (pingcap#448)

01e20d0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Add replace statement #448

*: Add replace statement #448

zimulala commented Oct 24, 2015

siddontang Oct 24, 2015

siddontang Oct 26, 2015

zimulala Oct 26, 2015

zimulala commented Oct 26, 2015

siddontang commented Oct 26, 2015

zimulala commented Oct 27, 2015

qiuyesuifeng Oct 27, 2015

siddontang Oct 27, 2015

zimulala Oct 27, 2015

zimulala commented Oct 27, 2015

qiuyesuifeng commented Oct 27, 2015

*: Add replace statement #448

*: Add replace statement #448

Conversation

zimulala commented Oct 24, 2015

siddontang Oct 24, 2015

Choose a reason for hiding this comment

siddontang Oct 26, 2015

Choose a reason for hiding this comment

zimulala Oct 26, 2015

Choose a reason for hiding this comment

zimulala commented Oct 26, 2015

siddontang commented Oct 26, 2015

zimulala commented Oct 27, 2015

qiuyesuifeng Oct 27, 2015

Choose a reason for hiding this comment

siddontang Oct 27, 2015

Choose a reason for hiding this comment

zimulala Oct 27, 2015

Choose a reason for hiding this comment

zimulala commented Oct 27, 2015

qiuyesuifeng commented Oct 27, 2015