Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: move lightning directory out of br #52247

Merged
merged 28 commits into from
Apr 1, 2024
Merged

lightning: move lightning directory out of br #52247

merged 28 commits into from
Apr 1, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #52182

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test: existing test should cover it
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 29, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Merging #52247 (e3bb5e4) into master (8bba826) will increase coverage by 0.7210%.
Report is 6 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #52247        +/-   ##
================================================
+ Coverage   70.6957%   71.4167%   +0.7210%     
================================================
  Files          1490       1562        +72     
  Lines        440284     457125     +16841     
================================================
+ Hits         311262     326464     +15202     
- Misses       109491     109751       +260     
- Partials      19531      20910      +1379
Flag Coverage Δ
integration 51.6732% <66.6666%> (?)
unit 70.9192% <ø> (+0.4086%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 34.7492% <ø> (-11.0494%) ⬇️

@D3Hunter D3Hunter changed the title [WIP]lightning: move lightning directory out of br lightning: move lightning directory out of br Apr 1, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 1, 2024

lightning ci pass https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/pull_lightning_integration_test/146/display/redirect

lance6716
lance6716 approved these changes Apr 1, 2024
View reviewed changes
Makefile
@@ -314,20 +314,20 @@ bench-daily:

build_tools: build_br build_lightning build_lightning-ctl

br_web:
@cd br/web && npm install && npm run build
lightning_web:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to notice CD team about the makefile entry changes

Copy link
Contributor Author

@D3Hunter D3Hunter Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's used by developers to generate some files, like checkpoints.pb.go and res_vfsdata.go, i will check with them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D3Hunter
CD will call build_tools task, so keep the command and output same will ensure the CD work well.

Thank you @lance6716 !

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Benjamin2037
Benjamin2037 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 02:23:40.04361423 +0000 UTC m=+237881.571154777: ☑️ agreed by lance6716.
  • 2024-04-01 02:52:39.416556963 +0000 UTC m=+239620.944097510: ☑️ agreed by Benjamin2037.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 1, 2024

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Apr 1, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 1, 2024

br ci pass https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/pull_br_integration_test/90/display/redirect

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 1, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Apr 1, 2024

@D3Hunter Can you also move the test files to the new folder, or you planed to do it in another PR?

@ti-chi-bot ti-chi-bot bot merged commit f2ea18c into pingcap:master Apr 1, 2024
40 checks passed
@D3Hunter D3Hunter deleted the move-lightning branch April 1, 2024 07:38
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 1, 2024

@D3Hunter Can you also move the test files to the new folder, or you planed to do it in another PR?

in later pr

imalasong pushed a commit to imalasong/tidb that referenced this pull request Apr 1, 2024
@D3Hunter @imalasong
lightning: move lightning directory out of br (pingcap#52247)
44fbb83 
ref pingcap#52182
Oreoxmt added a commit to Oreoxmt/docs-cn that referenced this pull request Apr 8, 2024
@Oreoxmt
tidb/pkg/lightning is moved out of br (ref: pingcap/tidb#52247)
38181a0
Oreoxmt added a commit to Oreoxmt/docs that referenced this pull request Apr 8, 2024
@Oreoxmt
tidb/pkg/lightning is moved out of br (ref: pingcap/tidb#52247)
a8f2e2a
This was referenced Apr 8, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
17 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 9, 2024
@Oreoxmt @ti-chi-bot
tidb/pkg/lightning is moved out of br (ref: pingcap/tidb#52247)
a049456
This was referenced Apr 9, 2024
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 9, 2024
@Oreoxmt @ti-chi-bot
tidb/pkg/lightning is moved out of br (ref: pingcap/tidb#52247)
f5fd71d
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo left review comments

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@3pointer 3pointer 3pointer approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@D3Hunter @wuhuizuo @lance6716 @3pointer @Benjamin2037