Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix broken links #17041

Merged
merged 6 commits into from
Apr 9, 2024
Merged

*: fix broken links #17041

merged 6 commits into from
Apr 9, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Apr 8, 2024

What is changed, added or deleted? (Required)

Fix broken links:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 labels Apr 8, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 8, 2024
@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 8, 2024

@D3Hunter Please review a8f2e2a

@Oreoxmt Oreoxmt requested a review from D3Hunter April 8, 2024 12:02
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 8, 2024

/cc @lilin90

@ti-chi-bot ti-chi-bot bot requested a review from lilin90 April 8, 2024 12:06
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lightning part lgtm

Copy link

ti-chi-bot bot commented Apr 8, 2024

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lightning part lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 05:52:06.483761134 +0000 UTC m=+941588.011301675: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Apr 9, 2024
@lilin90
Copy link
Member

lilin90 commented Apr 9, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit f788080 into pingcap:master Apr 9, 2024
8 of 9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 9, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17062.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17063.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
17 tasks
@Oreoxmt Oreoxmt deleted the fix/broken-links branch April 9, 2024 07:03
ti-chi-bot bot pushed a commit that referenced this pull request Apr 9, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Apr 9, 2024
@lilin90 lilin90 mentioned this pull request Apr 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants