Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: set a collation according to the arguments for ifnull in constant folding (#52119) #52130

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52119

What problem does this PR solve?

Issue Number: close #51765

Problem Summary:

The ifnull has different behavior in inferring collation for constant folding and normal execution path.

What changed and how does it work?

Set the collation according to the first argument in the path of constant folding.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Fix the issue that the collation of `ifnull` expression is different with MySQL when constant folding applies.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 27, 2024
Signed-off-by: Yang Keao <[email protected]>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 11, 2024
@YangKeao YangKeao requested a review from lcwangchao April 11, 2024 08:10
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 12, 2024
@YangKeao
Copy link
Member

/retest

@YangKeao YangKeao requested a review from zanmato1984 May 21, 2024 08:35
Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2024
Copy link

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-11 08:10:51.681309982 +0000 UTC m=+1122713.208850529: ☑️ agreed by YangKeao.
  • 2024-05-21 08:55:54.973831101 +0000 UTC m=+2161908.730966671: ☑️ agreed by zanmato1984.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@31c60e0). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52130   +/-   ##
================================================
  Coverage               ?   72.1694%           
================================================
  Files                  ?       1411           
  Lines                  ?     410933           
  Branches               ?          0           
================================================
  Hits                   ?     296568           
  Misses                 ?      94585           
  Partials               ?      19780           
Flag Coverage Δ
unit 72.1694% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4490% <0.0000%> (?)

@YangKeao
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0f107c2 into pingcap:release-7.5 May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants