-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: set a collation according to the arguments for ifnull
in constant folding (#52119)
#52130
expression: set a collation according to the arguments for ifnull
in constant folding (#52119)
#52130
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #52130 +/- ##
================================================
Coverage ? 72.1694%
================================================
Files ? 1411
Lines ? 410933
Branches ? 0
================================================
Hits ? 296568
Misses ? 94585
Partials ? 19780
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #52119
What problem does this PR solve?
Issue Number: close #51765
Problem Summary:
The
ifnull
has different behavior in inferring collation for constant folding and normal execution path.What changed and how does it work?
Set the collation according to the first argument in the path of constant folding.
Check List
Tests
Release note