-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: set a collation according to the arguments for ifnull
in constant folding
#52119
Conversation
Signed-off-by: Yang Keao <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52119 +/- ##
=================================================
- Coverage 70.6856% 54.7105% -15.9751%
=================================================
Files 1486 1597 +111
Lines 439484 609164 +169680
=================================================
+ Hits 310652 333277 +22625
- Misses 109326 252663 +143337
- Partials 19506 23224 +3718
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zanmato1984, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/check-issue-triage-complete |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #51765
Problem Summary:
The
ifnull
has different behavior in inferring collation for constant folding and normal execution path.What changed and how does it work?
Set the collation according to the first argument in the path of constant folding.
Check List
Tests
Release note