ddl: do not unset involving schema on EntryTooLarge error (#51963)

[ti-chi-bot]

This is an automated cherry-pick of #51963

What problem does this PR solve?

Issue Number: close #51962

Problem Summary:

tidb/pkg/ddl/ddl_worker.go

Lines 544 to 565 in 274d5e2

	func (w *worker) handleUpdateJobError(t *meta.Meta, job *model.Job, err error) error {
	if err == nil {
	return nil
	}
	if kv.ErrEntryTooLarge.Equal(err) {
	w.jobLogger(job).Warn("update DDL job failed", zap.String("job", job.String()), zap.Error(err))
	w.sess.Rollback()
	err1 := w.sess.Begin()
	if err1 != nil {
	return errors.Trace(err1)
	}
	// Reduce this txn entry size.
	job.BinlogInfo.Clean()
	job.InvolvingSchemaInfo = nil
	job.Error = toTError(err)
	job.ErrorCount++
	job.SchemaState = model.StateNone
	job.State = model.JobStateCancelled
	err = w.finishDDLJob(t, job)
	}
	return errors.Trace(err)
	}

We should not set job.InvolvingSchemaInfo to nil even if this txn size is too large, because we need this field to "unblock" other DDLs that change the same schemas/tables.

What changed and how does it work?

See 'Files Changed'.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[Benjamin2037]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [Benjamin2037,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-21 04:59:56.791835324 +0000 UTC m=+1525623.814081713: ☑️ agreed by Benjamin2037.
• 2024-03-21 06:42:44.128456864 +0000 UTC m=+1531791.150703251: ☑️ agreed by zimulala.

[tangenta]

/retest

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@bca83e6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.0     #51967   +/-   ##
================================================
  Coverage               ?   70.7735%           
================================================
  Files                  ?       1477           
  Lines                  ?     439406           
  Branches               ?          0           
================================================
  Hits                   ?     310983           
  Misses                 ?     108945           
  Partials               ?      19478           

Flag	Coverage Δ
unit	70.5143% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	46.1364% <0.0000%> (?)