reset lease time after bootstrap #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| // IsBootstrapped returns whether we have already run bootstrap or not. | ||
| // return true means we don't need doing any other bootstrap. | ||
| func (m *Meta) IsBootstrapped() (bool, error) { | ||
| value, err := m.txn.GetInt64(mBootstrapKey) |
There was a problem hiding this comment.
Why not use Get but GetInt64， seems in line 534 u set "1".
There was a problem hiding this comment.
For set "1", we can use GetInt64 to fetch this number directly, no need to do another conversation.
siddontang
added a commit
that referenced
this pull request
Nov 5, 2015
reset lease time after bootstrap
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
Signed-off-by: mantuliu <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * sem placement rule (pingcap#222) sem placement rule Signed-off-by: AmoebaProtozoa <[email protected]> * make check Signed-off-by: AmoebaProtozoa <[email protected]> * change statement config by serverless version (pingcap#247) * change statement config by serverless version --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> * limit the max_execution_time in serverless tier (pingcap#385) Signed-off-by: AmoebaProtozoa <[email protected]> * off 1pc (pingcap#404) * off 1pc Signed-off-by: ystaticy <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> Signed-off-by: zeminzhou <[email protected]> Signed-off-by: ystaticy <[email protected]> Co-authored-by: ystaticy <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngaut