*: Avoid store plaintext password in mysql.user table. #304

shenli · 2015-10-04T14:33:24Z

Store hashed password.

ngaut · 2015-10-05T03:48:47Z

util/auth.go

+func DecodePassword(pwd string) ([]byte, error) {
+	x, err := hex.DecodeString(pwd)
+	if err != nil {
+		return []byte{}, errors.Trace(err)


Why not just return nil instead of []byte{}

kevincox · 2015-10-06T23:34:26Z

Shouldn't some salt be used? Or ideally a password hashing library so that someone with cryptographic knowledge can maintain the hashing.

qiuyesuifeng · 2015-10-07T01:36:29Z

util/auth.go

+
+// CalcPassword is the algorithm convert hashed password to auth string.
+// See: https://dev.mysql.com/doc/internals/en/secure-password-authentication.html
+// SHA1( password ) XOR SHA1( "20-bytes random data from server" <concat> SHA1( SHA1( password ) ) )


Seems SHA1( SHA1( password ) ) should be SHA1( password ) in comment?

In the comment "password" is the origin password. Maybe I should change the name of the parameter.

PTAL @qiuyesuifeng

shenli · 2015-10-07T03:00:57Z

@kevincox The salt is a random data generated for each client connection. The parameter scramble of CalcPassword function in auth.go is the salt.
MySQL client uses server-generated salt and password to caculate a cryptographic authstring. Server use the same algorithm and compare check if the result is the same with client.

siddontang · 2015-10-07T03:23:34Z

LGTM

*: Avoid store plaintext password in mysql.user table.

kevincox · 2015-10-07T13:50:27Z

Ok, I see where the salt comes in but I'm still unconvinced about the overall system. It appears that there is no way to upgrade the hashes in the future and SHA1 is already getting chipped away at. Also three hashes on SHA1 is very very cheep so it won't do much to stop brute force attacks.

…_RESULT (pingcap#304) * Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT * update test case * code formatting * word wrap

…_RESULT (#304) * Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT * update test case * code formatting * word wrap

* init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]>

* Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * sem placement rule (pingcap#222) sem placement rule Signed-off-by: AmoebaProtozoa <[email protected]> * make check Signed-off-by: AmoebaProtozoa <[email protected]> * change statement config by serverless version (pingcap#247) * change statement config by serverless version --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> * limit the max_execution_time in serverless tier (pingcap#385) Signed-off-by: AmoebaProtozoa <[email protected]> * off 1pc (pingcap#404) * off 1pc Signed-off-by: ystaticy <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> Signed-off-by: zeminzhou <[email protected]> Signed-off-by: ystaticy <[email protected]> Co-authored-by: ystaticy <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: iosmanthus <[email protected]>

* Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * add test flag that can disable feature control (pingcap#328) Signed-off-by: David <[email protected]> Co-authored-by: iosmanthus <[email protected]> * Adds a feature whitelist at planbuild stage (pingcap#304) * init Signed-off-by: David <[email protected]> * format errors Signed-off-by: David <[email protected]> * restrict information schema Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * bazel Signed-off-by: David <[email protected]> * fmt Signed-off-by: David <[email protected]> * disable datadir Signed-off-by: David <[email protected]> * add ttl check for create and alter table Signed-off-by: David <[email protected]> * create table ttl Signed-off-by: David <[email protected]> * address comments Signed-off-by: David <[email protected]> * update error doc Signed-off-by: David <[email protected]> * add the back to the error message Signed-off-by: David <[email protected]> * unblock 'SHOW CONFIG' for lightning Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> # Conflicts: # ddl/BUILD.bazel # errno/errname.go # util/sem/sem.go * disable validate password (pingcap#465) Signed-off-by: AmoebaProtozoa <[email protected]> * turn on validate password and set special char count to 0 (pingcap#464) * serverless version 16 Signed-off-by: AmoebaProtozoa <[email protected]> * fix typo in comments Signed-off-by: AmoebaProtozoa <[email protected]> * set special char to 0 Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> * disabling password validation (pingcap#467) * skip enabling password validation Signed-off-by: AmoebaProtozoa <[email protected]> * fix global variable Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit waittimeout (pingcap#468) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb-isolation-read-engines (pingcap#470) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb_txn_mode (pingcap#471) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb-cdc-write-source (pingcap#473) Signed-off-by: AmoebaProtozoa <[email protected]> * allow edit tidb_placement_mode (pingcap#474) Signed-off-by: AmoebaProtozoa <[email protected]> * please the checker Signed-off-by: AmoebaProtozoa <[email protected]> * sem enable now returns error on fail Signed-off-by: AmoebaProtozoa <[email protected]> * make check Signed-off-by: AmoebaProtozoa <[email protected]> --------- Signed-off-by: David <[email protected]> Signed-off-by: AmoebaProtozoa <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: zzm <[email protected]>

*: Avoid store plaintext password in mysql.user table.

948fa8b

Store hashed password.

ngaut reviewed Oct 5, 2015
View reviewed changes

util: Address comment and add unittest for auth.go

58d3c37

qiuyesuifeng reviewed Oct 7, 2015
View reviewed changes

util: Address comment

a926f6f

shenli added a commit that referenced this pull request Oct 7, 2015

Merge pull request #304 from pingcap/shenli/hash-password

85e96de

*: Avoid store plaintext password in mysql.user table.

shenli merged commit 85e96de into master Oct 7, 2015

shenli deleted the shenli/hash-password branch October 7, 2015 03:38

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021

restore: fix typo (pingcap#304)

f3ce13e

ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021

[parser] Parser: Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER…

e8b48ae

…_RESULT (#304) * Support SQL_BIG_RESULT, SQL_SMALL_RESULT, SQL_BUFFER_RESULT * update test case * code formatting * word wrap

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Avoid store plaintext password in mysql.user table. #304

*: Avoid store plaintext password in mysql.user table. #304

shenli commented Oct 4, 2015

ngaut Oct 5, 2015

shenli Oct 5, 2015

kevincox commented Oct 6, 2015

qiuyesuifeng Oct 7, 2015

shenli Oct 7, 2015

shenli Oct 7, 2015

shenli commented Oct 7, 2015

siddontang commented Oct 7, 2015

kevincox commented Oct 7, 2015

*: Avoid store plaintext password in mysql.user table. #304

*: Avoid store plaintext password in mysql.user table. #304

Conversation

shenli commented Oct 4, 2015

ngaut Oct 5, 2015

Choose a reason for hiding this comment

shenli Oct 5, 2015

Choose a reason for hiding this comment

kevincox commented Oct 6, 2015

qiuyesuifeng Oct 7, 2015

Choose a reason for hiding this comment

shenli Oct 7, 2015

Choose a reason for hiding this comment

shenli Oct 7, 2015

Choose a reason for hiding this comment

shenli commented Oct 7, 2015

siddontang commented Oct 7, 2015

kevincox commented Oct 7, 2015