Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix intersection type mv index's filters mutations composition (#50379) #50396

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50379

What problem does this PR solve?

Issue Number: close #50380

Problem Summary:

What changed and how does it work?

fix the AND mv index filter mutations generating logic.
SELECT * FROM t WHERE 15975127 member of (domains) AND 15975128 member of (domains) AND a = 1 AND b = 2
for mv index mvi(a, domains, b)
the accessFilters should be [a = 1, ?, b = 1], here ? is pos occupation here stands for set {15975127 member of (domains), 15975128 member of (domains)}
when building index partial path, we have two mutation here
a=1 and 15975127 member of (domains) and b=2
a=1 and 15975128 member of (domains) and b=2

the generation mistake detail can ref the issue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix intersection type mv index's filters mutations composition

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Jan 13, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2024
Copy link

ti-chi-bot bot commented Jan 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-13 05:37:15.194158814 +0000 UTC m=+680824.778412486: ☑️ agreed by AilinKid.
  • 2024-01-13 14:17:11.064502515 +0000 UTC m=+19872.628800214: ☑️ agreed by hawkingrei.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.6@2df8bd1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.6     #50396   +/-   ##
================================================
  Coverage               ?   70.0434%           
================================================
  Files                  ?       1436           
  Lines                  ?     419484           
  Branches               ?          0           
================================================
  Hits                   ?     293821           
  Misses                 ?     105388           
  Partials               ?      20275           
Flag Coverage Δ
unit 70.0434% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 49.7829% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 16, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

ti-chi-bot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, fixdb, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,fixdb,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit c88db03 into pingcap:release-7.6 Jan 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants